[wp-trac] [WordPress Trac] #55981: Twenty Nineteen: Pullquote Block Text Color not reflected on frontend

WordPress Trac noreply at wordpress.org
Fri Jun 24 14:59:51 UTC 2022


#55981: Twenty Nineteen: Pullquote Block Text Color not reflected on frontend
---------------------------+---------------------
 Reporter:  nithins53      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  6.1
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  css
---------------------------+---------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-refresh => has-patch
 * milestone:  Future Release => 6.1


Comment:

 Thanks for the patch! Removing the color from the `blockquote` element
 works with trunk and the latest Gutenberg. Then it falls back to the body
 color (also `#111`) when no special colors are specified.

 However, there was a reason to add it in the first place. The editor's
 theme.css used to make the block a gray color, which was
 [https://github.com/WordPress/gutenberg/pull/26684 changed to
 `currentColor` for Gutenberg 9.4].
 {{{
 .wp-block-pullquote {
   color: #40464d;
 }
 }}}

 To accommodate older versions of WordPress, Twenty Nineteen probably could
 **move** that color from the `blockquote` to the block container.

 {{{
         .wp-block-pullquote {
                 color: $color__text-main;
                 border-color: transparent;
                 border-width: 2px;
                 padding: $size__spacing-unit;

                 blockquote {
                         border: none;
                         margin-top: calc(4 * #{ $size__spacing-unit});
                         margin-bottom: calc(4.33 * #{ $size__spacing-
 unit});
                         margin-right: 0;
                         padding-left: 0;
                 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55981#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list