[wp-trac] [WordPress Trac] #56064: PHPCS issue in wp-admin/include/media.php .

WordPress Trac noreply at wordpress.org
Fri Jun 24 13:45:45 UTC 2022

#56064: PHPCS issue in wp-admin/include/media.php .
 Reporter:  smit08            |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  6.1
Component:  Media             |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  coding-standards

Comment (by SergeyBiryukov):

 Hi there, thanks for the patch!

 It looks like `esc_attr()` was used here as of [12051] / #10252, since
 `esc_url()` did not work correctly with some accented characters at the
 time, see #10859.

 Since #10859 was fixed in [12199], and `esc_url()` no longer returns an
 empty string for the URL listed there in my testing, I think we should
 indeed be able to `esc_url()` here.

Ticket URL: <https://core.trac.wordpress.org/ticket/56064#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list