[wp-trac] [WordPress Trac] #56021: Rename or deprecate assertDiscardWhitespace()
WordPress Trac
noreply at wordpress.org
Mon Jun 20 19:08:42 UTC 2022
#56021: Rename or deprecate assertDiscardWhitespace()
------------------------------+---------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 6.1
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
------------------------------+---------------------
Comment (by SergeyBiryukov):
Replying to [comment:4 jrf]:
> PHPUnit 10 will introduce two PHPUnit native functions along the same
lines:
>
> > Added
> > * [https://github.com/sebastianbergmann/phpunit/issues/4641 #4641]:
`assertStringEqualsStringIgnoringLineEndings()` and
`assertStringContainsStringIgnoringLineEndings()`
>
> Ref:
https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-10.0.md
Thanks! This seems like it has to do more with `assertSameIgnoreEOL()` and
`assertEqualsIgnoreEOL()`, which are not changing at this time but can
indeed be replaced with these new functions when they are available.
`assertDiscardWhitespace()` is a bit different and still seems worth
renaming to mention what exactly is being asserted and the underlying
`assertEquals()` usage.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56021#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list