[wp-trac] [WordPress Trac] #53220: Twenty Twenty-One: Refactor or remove navigation item padding CSS

WordPress Trac noreply at wordpress.org
Fri Jun 17 10:13:48 UTC 2022


#53220: Twenty Twenty-One: Refactor or remove navigation item padding CSS
---------------------------+------------------------------
 Reporter:  Joen           |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.6
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------

Comment (by poena):

 For [https://github.com/WordPress/gutenberg/pull/34171 Gutenberg 11.5],
 the CSS class names in the navigation block were updated. The padding in
 the theme styles is not applied on WordPress version 5.9 or 6.0.

 There are a few things I think that we need to consider:

 -Twenty Twenty-one is possibly the last classic theme (Twenty Twenty-Three
 has not been announced yet), so we should try to solve these types of
 issues.

 -WordPress 5.6 (reported version) - 5.8 does not support the navigation
 block without Gutenberg. And Gutenberg has a minimum required WordPress
 version which is 5.8. This minimum required version will keep increasing.

 -Generally I would prefer to not remove CSS variables as they may be used
 by child themes.
 But because of the above reasons, I think removing them would only have a
 low negative impact, and a positive impact for users who are on older
 versions of WordPress and Gutenberg.



 We may need to discuss if we should limit the loading of some CSS to older
 versions of WordPress.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53220#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list