[wp-trac] [WordPress Trac] #24661: remove_accents is not removing combining accents

[WordPress Trac]

#24661: remove_accents is not removing combining accents
-------------------------------------------------+-------------------------
 Reporter:  NumidWasNotAvailable                 |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Formatting                           |     Version:  1.2.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     testing


Comment:

 Thank you, everyone who has contributed toward this issue, and @zodiac1978
 and @rodrigosevero for your relatively recent touches! 🙌🏻

 == Summary ==
 This ticket has been around a while, so to summarize the situation in
 2022:
 - The `intl` extension's
 [https://www.php.net/manual/en/normalizer.normalize.php
 normalizer_normalize] support was added to PHP 5.3.0+.
 - For native support, PHP needs to be built with `--enable-intl` (thanks
 @jrf via [https://core.trac.wordpress.org/ticket/52654#comment:13
 #52654#comment:13]), if not already included in your bundle.
 - `intl` support can alternatively be
 [https://www.php.net/manual/en/intl.installation.php installed via PECL].
 - `intl` [https://make.wordpress.org/hosting/2021/05/20/why-hosters-
 should-install-the-php-intl-extension/ has been recommended] and is
 officially [https://make.wordpress.org/hosting/handbook/server-environment
 /#php-extensions referenced in the Hosting Handbook].
 - WordPress currently [https://make.wordpress.org/core/handbook/references
 /php-compatibility-and-wordpress-versions/ supports PHP 5.6+].
 - The
 [https://core.trac.wordpress.org/attachment/ticket/24661/normalize_before_removing_accents.patch
 proposed patch] includes the recommended `function_exists()` check to
 ensure support.

 With these factors it seems we have a pretty good runway to move this
 forward 🤞🏻. [Famous last words.]

 == Refresh ==
 Based on @rodrigosevero's patch, I've opened [https://github.com/WordPress
 /wordpress-develop/pull/2820 PR 2820] as a refresh, and added a unit test
 for NFD sequences (alternate Unicode representations of the same
 characters) that are not part of the current function's `strtr()`
 translation array.

 The unit test includes Latin1 Supplement, but I wouldn't mind feedback on
 other sets to test, if necessary.

 Related issues: #30130, #35951, #47763, #52654.

 CC: @azaozz @hellofromTonya @SergeyBiryukov

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/24661#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform