[wp-trac] [WordPress Trac] #51657: Correct displaying the _doing_it_wrong() message for add_theme_support( 'html5' )

WordPress Trac noreply at wordpress.org
Thu Jun 16 12:38:27 UTC 2022

#51657: Correct displaying the _doing_it_wrong() message for add_theme_support(
'html5' )
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.0
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  dev-note                                       |

Comment (by bobbingwide):

 > Just wonder if we want to change the version param. I think it's fine to
 keep the reference to the version it was added, but on another hand, it
 would be nice to upgrade the version to 5.7.0 as the notice will be
 displayed for the very first time. Any thought?

 I've just spent a while trying to understand why I've not seen this
 message before WordPress 6.0
 I agree that the original doing_it_wrong was added in 3.6.1.

 But up to 5.9.3 everything was OK since the code magically defaulted the
 args array.
 It would have been nice to have seen something that indicated there'd been
 a further change in 6.0

Ticket URL: <https://core.trac.wordpress.org/ticket/51657#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list