[wp-trac] [WordPress Trac] #53125: Logged error messages should not be translateable

[WordPress Trac]

#53125: Logged error messages should not be translateable
-----------------------------------+---------------------
 Reporter:  malthert               |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  6.1
Component:  Database               |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [comment:1 SergeyBiryukov]:
 > Just noting that this message [source:tags/5.7.1/src/wp-includes/wp-
 db.php?marks=1491-1521#L1488 can also be displayed to the user], depending
 on the `$show_errors` property value, e.g. when `WP_DEBUG` and
 `WP_DEBUG_DISPLAY` are both true.

 It looks like this comment was not entirely correct, as the message
 displayed to the user here is not the same as the one that is logged.

 The PR should be good to go. One minor adjustment I would make is that
 `wp_load_translations_early()` can now be called later, only if
 `$this->show_errors` is true. This can be addressed on commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53125#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform