[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.1
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-unit-   |     Focuses:
  tests has-patch needs-dev-note needs-testing   |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  early has-testing-info needs-unit-tests has-patch needs-dev-
     note =>
     early has-testing-info needs-unit-tests has-patch needs-dev-note
     needs-testing


Comment:

 == Summary of today's Upgrade/Install component meeting

 Where: in Making WordPress slack #core-auto-updates channel
 Link: https://wordpress.slack.com/archives/CULBN711P/p1655229327510739

 **tl;dr**

 👉 More testing and feedback is needed from web hosts and extenders before
 this lands in Core.

 === Discussion

 * Had trouble getting web hosts to test and give feedback
 ''Without this feedback, how do we know the PR won't impact them or their
 customers?''****

 * Core first? Or feature plugin?

 **Previous thinking:**
 Get it into Core first and then validation that it works would come
 because it's in `trunk`.

 **New thinking:**
 Get feedback and testing first to validate it does work.
 Then when ready, land it in Core.

 * Add temporary code into Core's Upgrader to invoke the feature plugin's
 `move_dir()`.

 Sergey shared there is precedence for doing this: [25590], [26865],
 [32625]. He also noted
 >Should probably be removed from the final release after branching if that
 doesn't happen earlier.

 === Action Items

 * Develop a testing and feedback strategy
    * Use the featured plugin for folks to test it
    * Make it easy for people to participate in testing and giving feedback
    * Define what kind of feedback is needed / wanted
    * Include outreach to web hosts and extenders
 * Need a PR that adds code to the Upgrader to invoke the feature plugin's
 `move_dir()` when the plugin is activated.
 * Once strategy is set, then publish a Make post to ask to ask for testing
 and feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:259>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform