[wp-trac] [WordPress Trac] #55652: Test tool and unit test improvements for 6.1

WordPress Trac noreply at wordpress.org
Sun Jun 5 09:30:08 UTC 2022

#55652: Test tool and unit test improvements for 6.1
 Reporter:  hellofromTonya            |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  6.1
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:

Comment (by desrosj):

 In [changeset:"53466" 53466]:
 #!CommitTicketReference repository="" revision="53466"
 Build/Test Tools: Prevent inaccurate “fixed” notifications in Slack.

 When searching for previous workflow runs by branch, GitHub currently
 includes matches within forks.

 If a contributor opens a pull request from their fork with a `head_ref`
 matching a Core branch that triggers a workflow on `push` event, the
 outcomes of the workflows associated with that pull request are currently
 used to determine if the previous workflow run had failed.

 The result is a false “fixed” notifications when a commit immediately
 follows a failed workflow run from the pull request.

 This adds a check to skip any workflow runs not triggered by a `push`
 event to prevent these inaccurate notifications.

 Props SergeyBiryukov.
 See #55652.

Ticket URL: <https://core.trac.wordpress.org/ticket/55652#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list