[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
WordPress Trac
noreply at wordpress.org
Sun Jul 31 12:52:11 UTC 2022
#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
----------------------------+-------------------------------
Reporter: hztyfoon | Owner: audrasjb
Type: defect (bug) | Status: reviewing
Priority: low | Milestone: 6.1
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: coding-standards
----------------------------+-------------------------------
Comment (by SergeyBiryukov):
Replying to [comment:21 costdev]:
> Instead, for known values, I'd suggest that we only make use of
`MINUTE_IN_SECONDS` when the value exceeds `59` seconds.
I agree, this makes sense.
For the four instances of `MINUTE_IN_SECONDS / 2` in [53714], that could
be a comment instead of the constant:
{{{
define( 'FS_TIMEOUT', 30 ); // 30 seconds.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list