[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
WordPress Trac
noreply at wordpress.org
Thu Jul 28 08:34:03 UTC 2022
#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
------------------------------------+-------------------------------
Reporter: hztyfoon | Owner: audrasjb
Type: defect (bug) | Status: reviewing
Priority: low | Milestone: 6.1
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: coding-standards
------------------------------------+-------------------------------
Changes (by audrasjb):
* keywords: has-patch changes-requested => has-patch dev-feedback
* priority: normal => low
Comment:
PR updated as per @SergeyBiryukov 's proposal.
@peterwilsoncc suggested to replace `MINUTE_IN_SECONDS / 2` with `0.5 *
MINUTE_IN_SECONDS`.
I **personally** find the former more readable than the latter.
That's not super important, but let's collect some feedback from other
committers before shipping this tiny enhancement ;)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list