[wp-trac] [WordPress Trac] #56231: WP_Http::make_absolute_url drops fragments

WordPress Trac noreply at wordpress.org
Mon Jul 25 09:58:56 UTC 2022

#56231: WP_Http::make_absolute_url drops fragments
 Reporter:  dshanske                               |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  6.1
Component:  HTTP API                               |     Version:  3.4
 Severity:  normal                                 |  Resolution:
 Keywords:  has-patch has-unit-tests dev-feedback  |     Focuses:

Comment (by schlessera):

 @costdev For acting on the URLs from the `Requests` side, I see no issue.
 `Requests` handles fragments just fine, and it doesn't care too much about
 whether you use them or not.

 The only issues I could see is from WordPress Core or plugins that don't
 expect URLs to contain fragments because they were historically missing.
 They might have a use for the `$include_fragments` flag, but then again,
 if you keep it `false` by default, you don't actually fix the bug, and if
 you keep it `true` by default, they will need to make a change to their
 code anyway - they could just as well fix the actual bug then.

Ticket URL: <https://core.trac.wordpress.org/ticket/56231#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list