[wp-trac] [WordPress Trac] #56007: Correct the escaping in documentation lookup for plugin and theme editor

[WordPress Trac]

#56007: Correct the escaping in documentation lookup for plugin and theme editor
------------------------------+-----------------------------
 Reporter:  SergeyBiryukov    |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  6.1
Component:  Administration    |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53758" 53758]:
 {{{
 #!CommitTicketReference repository="" revision="53758"
 Administration: Correct the escaping in documentation lookup for plugin
 and theme editor.

 This brings consistency to similar code fragments that evolved in slightly
 different ways over the years:

 * A check that the list of functions is not empty now exists in both
 editors.
 * "Function Name..." is an option label, not an attribute, so
 `esc_html__()` is the correct function here.
 * `esc_attr( urlencode( $function ) )` in the theme editor is replaced
 with `esc_attr( $function )`.
 * `htmlspecialchars( $function )` in the theme editor is replaced with
 `esc_html( $function )`.

 Follow-up to [10607], [10879], [11110], [11173], [11204], [11671],
 [14989].

 Props aristath, justinahinon, poena, audrasjb, pratiweb, SergeyBiryukov.
 Fixes #56007.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56007#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform