[wp-trac] [WordPress Trac] #56219: Importer plugin's PHPUnit tests fail on PHP 8.1
WordPress Trac
noreply at wordpress.org
Thu Jul 14 20:24:39 UTC 2022
#56219: Importer plugin's PHPUnit tests fail on PHP 8.1
-------------------------------------+------------------------------
Reporter: antonvlasenko | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Plugins | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+------------------------------
Comment (by jrf):
@antonvlasenko Couple of points here:
1. The changes you are suggesting are for an external dependency. That
dependency has already released a version compatible with PHP 8.1 (and 8.2
for that matter). WP just hasn't upgraded yet. See:
https://core.trac.wordpress.org/ticket/54504
2. The only reason the Importer plugin has a PHPUnit restriction is
because it is needed to support older WP versions. With the WP 5.9 or
higher, all necessary PHPUnit versions are supported. You should NOT run
with `--ignore-platform-reqs`. Instead you should run `composer remove
--dev phpunit/phpunit` (this will not actually remove phpunit, but will
remove the version restriction). See: https://github.com/WordPress
/wordpress-
importer/blob/c0e188a85c57fadde914e397bd4b0a9c104e5f17/.github/workflows/test.yml#L108-L146
for the full details and explanation.
I suggest closing this ticket as a duplicate of #54504.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56219#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list