[wp-trac] [WordPress Trac] #56198: Check cache key type

[WordPress Trac]

#56198: Check cache key type
-------------------------+--------------------------
 Reporter:  tillkruess   |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  6.1
Component:  Cache API    |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  performance
-------------------------+--------------------------

Comment (by tillkruess):

 I haven't dug into these, but 5 tests are now failing because they are
 using non-empty strings as cache keys. Likely issues in core.

 {{{
 1) Tests_User::test_wp_insert_user_with_meta
 Unexpected incorrect usage notice for add.
 Cache key must not be an empty string. (This message was added in version
 6.1.0.)

 2) Tests_User_GetUserCount::test_get_user_count_on_different_network
 Unexpected incorrect usage notice for add.
 Cache key must not be an empty string. (This message was added in version
 6.1.0.)

 3) Tests_User_GetUserCount::test_enable_live_network_user_counts_filter
 Unexpected incorrect usage notice for add.
 Cache key must not be an empty string. (This message was added in version
 6.1.0.)


 4) Tests_User_GetUserCount::test_get_user_count_update_on_delete_multisite
 Unexpected incorrect usage notice for add.
 Cache key must not be an empty string. (This message was added in version
 6.1.0.)

 5) Tests_User_Slashes::test_wp_insert_user
 Unexpected incorrect usage notice for add.
 Cache key must not be an empty string. (This message was added in version
 6.1.0.)
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56198#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform