[wp-trac] [WordPress Trac] #35717: Audit the .icon16 selectors in admin-menu.css
WordPress Trac
noreply at wordpress.org
Tue Jul 5 18:43:59 UTC 2022
#35717: Audit the .icon16 selectors in admin-menu.css
-----------------------------+----------------------
Reporter: afercia | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.1
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: close has-patch | Focuses: ui, css
-----------------------------+----------------------
Changes (by desrosj):
* keywords: needs-patch => close has-patch
* milestone: => 6.1
Comment:
I came across this one going through open tickets missing a milestone.
Normally, I advocate for leaving code whenever there's the potential for a
site to break, but I think enough time has passed and this one is
acceptable to remove.
Some notes from my investigation:
- The one theme using the `.icon16` class only has 50 installs. And when
the relevant CSS is removed nothing actually "breaks". The icons just
disappear.
- This is admin only facing, should not affect regular site visitors.
- An repeat search with
[https://wpdirectory.net/search/01G77R5TJ451VFK2YP8DFAW02W updated results
shows more matches, but fewer total active installs].
- The results show a lot of false positives and instances where plugins
are using that class for something unrelated.
Moving this to the 6.1 milestone and giving a bit more time for additional
thoughts to be added.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35717#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list