[wp-trac] [WordPress Trac] #55000: 5.9 kills gutenberg blocks

[WordPress Trac]

#55000: 5.9 kills gutenberg blocks
--------------------------+------------------------------
 Reporter:  stevesand     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by glendaviesnz):

 > No for some reason the migration is not happening.

 My apologies, as @Clorith mentions the migration only happens when you
 edit a post containing a Cover block.

 But the styles were supposed to still be in place to maintain the
 background opacity for existing blocks without the need to edit them. I
 tried viewing an un-migrated block on 5.9 and it appears to work:

 [[Image(https://i.imgur.com/zAYUnGz.png)]]

 however - it is defaulting to 0.5 opacity instead of respecting the actual
 dim ratio that was set for some reason. Were your blocks still showing
 some opacity or was the opacity gone completely?

 I will see if we can get a patch up to resolve this issue to the old
 blocks respect the opacity that is set rather than defaulting back to 0.5.


 > To solve it I ran a replace for all "wp-block-cover has-background-
 dim-40 has-background-dim" to replace it with only "wp-block-cover". The
 <span> is added but the classes from the root div are not removed. Making
 the divs super dark.

 With doing this you might find that you get an invalid block error when
 you try to edit those blocks in the editor. Another solution may be to add
 the following additional styles to the sites -
 https://gist.github.com/glendaviesnz/b3480d37ff0ea75103cea8ca5bd1796b

 > I discovered some more problems when restoring clients websites.
 > The border radius is gone from buttons, breaks previous buttons.

 Are you able to add separate tickets for these ones please as it makes it
 easier to follow up then?

 > The class "is-light" is added cover blocks, making text dark, not sure
 where this class stems from.

 The reasoning behind this change can be found here
 https://github.com/WordPress/gutenberg/pull/33541 - if that doesn't seem
 to make sense in your context, then go ahead and add a new ticket for this
 problem as well.

 Thanks again for taking the time to report these problems.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55000#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform