[wp-trac] [WordPress Trac] #54582: Problem with deleting old files at the end of a core update when the filesystem is case-insensitive

[WordPress Trac]

#54582: Problem with deleting old files at the end of a core update when the
filesystem is case-insensitive
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  6.0
Component:  Upgrade/Install                      |     Version:
 Severity:  major                                |  Resolution:
 Keywords:  needs-patch needs-testing early      |     Focuses:
  early-like-actually-early                      |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 I just tested the case-insensitive file cleanup code from wp-cli 2.6.0 and
 it seems to work great!  I did the following:

 1. fresh install of 5.8.3 on Windows (WAMP stack, w/ PHP 7.4.16)
 2. `wp core update --version=5.8-beta1`
    * this step attempted to recreate the conditions that caused me to open
 this ticket originally
    * the correct files were delete and `wp_remote_get()` worked fine
 3. `wp core update --version=5.8-beta2`
    * the correct files were delete and `wp_remote_get()` worked fine
    * this step also showed that the new code file cleanup code in wp-cli
 2.6.0 meant that the
 "[https://wordpress.org/news/2021/12/wordpress-5-9-beta-2/ 2 step update
 process]" from the 5.9-beta2 announcement post isn't necessary with this
 new code

 So, at this time, it seems the approach taken in wp-cli 2.6.0 is a good
 candidate for a patch for core (for updating from the dashboard).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54582#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform