[wp-trac] [WordPress Trac] #54886: "Show hidden updates" button is invisible

[WordPress Trac]

#54886: "Show hidden updates" button is invisible
-------------------------------------+-------------------------------------
 Reporter:  SergeyBiryukov           |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.9.1
Component:  Upgrade/Install          |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, javascript,
  screenshots fixed-major            |  administration
-------------------------------------+-------------------------------------
Description changed by SergeyBiryukov:

Old description:

> Background: #43242, #49407.
>
> Reported by @malinevskiy on Russian support forums:
> [https://ru.wordpress.org/support/topic/как-вернуть-кнопку-обновить-
> сейчас/ How do I bring back the Update Now button?]
>
> In recent WordPress versions, the "Show hidden updates" button on the
> WordPress Updates screen is invisible and cannot be used.
>
> Steps to reproduce:
> 1. Install a (not the latest) localized package, e.g.
> [https://ru.wordpress.org/wordpress-5.7-ru_RU.zip WordPress 5.7 (ru_RU)].
> 2. Make sure to complete the installation in a non-English language, as
> the "Hide this update" button is only available for localized installs.
> 2. Go to the WordPress Updates screen.
> 3. Next to the update to the latest localized version (currently
> WordPress 5.8.3–ru_RU), click "Hide this update".
> 4. Note that the hidden update is completely gone from the screen and
> cannot be brought back.
>
> The expected result is to get a "Show hidden updates" button, which
> displays a list of previously hidden updates with an option to bring them
> back or update right away.
>
> I have traced the issue back to [48323]. Before that change, the button
> is visible and works as expected. There is some JS code on the WordPress
> Updates screen to handle that button, which uses the
> [https://api.jquery.com/toggle-event/ .toggle( handler, handler )] method
> signature deprecated in jQuery 1.8 and removed in jQuery 1.9. Apparently
> this functionality was previously polyfilled by jQuery Migrate 1.4.1, and
> is no longer available after its removal.
>
> The JS code in question should be updated for jQuery 1.9+. This is not
> strictly a WordPress 5.9 issue, but still a recent regression, so I'm
> proposing the fix for 5.9.1 consideration.

New description:

 Background: #43242, #49407.

 Reported by @malinevskiy on Russian support forums:
 [https://ru.wordpress.org/support/topic/как-вернуть-кнопку-обновить-
 сейчас/ How do I bring back the Update Now button?]

 In recent WordPress versions, the "Show hidden updates" button on the
 WordPress Updates screen is invisible and cannot be used.

 Steps to reproduce:
 1. Install a localized package (not the latest), e.g.
 [https://ru.wordpress.org/wordpress-5.7-ru_RU.zip WordPress 5.7-ru_RU].
 2. Make sure to complete the installation in a non-English language, as
 the "Hide this update" button is only available for localized installs.
 2. Go to the WordPress Updates screen.
 3. Next to the update to the latest localized version (currently WordPress
 5.8.3–ru_RU), click "Hide this update".
 4. Note that the hidden update is completely gone from the screen and
 cannot be brought back.

 The expected result is to get a "Show hidden updates" button, which
 displays a list of previously hidden updates with an option to bring them
 back or update right away.

 I have traced the issue back to [48323]. Before that change, the button is
 visible and works as expected. There is some JS code on the WordPress
 Updates screen to handle that button, which uses the
 [https://api.jquery.com/toggle-event/ .toggle( handler, handler )] method
 signature deprecated in jQuery 1.8 and removed in jQuery 1.9. Apparently
 this functionality was previously polyfilled by jQuery Migrate 1.4.1, and
 is no longer available after its removal.

 The JS code in question should be updated for jQuery 1.9+. This is not
 strictly a WordPress 5.9 issue, but still a recent regression, so I'm
 proposing the fix for 5.9.1 consideration.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54886#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform