[wp-trac] [WordPress Trac] #54806: Site Editor: Remote block patterns are not loaded

WordPress Trac noreply at wordpress.org
Mon Jan 17 17:01:13 UTC 2022

#54806: Site Editor: Remote block patterns are not loaded
 Reporter:  noisysocks                         |       Owner:  (none)
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  5.9
Component:  Editor                             |     Version:
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch has-testing-info commit  |     Focuses:
Changes (by hellofromTonya):

 * keywords:  has-patch has-testing-info => has-patch has-testing-info


 Capturing comments from my review of the PR:

 - The changes apply to only the block editor and site editor screens 👍
 - Function signature deprecation is consistent with other instances in
 Core 👍
 - Backwards compatibility functionality in `_load_remote_block_patterns()`
 is retained 👍
 - In testing, this PR resolves the reported issue ([#comment:8 see the
 test report]) while not impacting the block editor 👍

 The solution works around the `current_screen` limitations to directly
 trigger remote pattern loading when on block or site editor screens.
 Should not impact other UIs/screens. I think this makes sense.

 LGTM 👍 Marking for `commit`.

 What do you think @peterwilsoncc?

Ticket URL: <https://core.trac.wordpress.org/ticket/54806#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list