[wp-trac] [WordPress Trac] #53493: Errors in `ms-files.php` aren't logged

[WordPress Trac]

#53493: Errors in `ms-files.php` aren't logged
-------------------------------------------+------------------------
 Reporter:  iandunn                        |       Owner:  iandunn
     Type:  enhancement                    |      Status:  reopened
 Priority:  low                            |   Milestone:  5.9
Component:  Upload                         |     Version:  3.0
 Severity:  normal                         |  Resolution:
 Keywords:  early has-patch needs-testing  |     Focuses:  multisite
-------------------------------------------+------------------------

Comment (by iandunn):

 Yeah, reverting sounds good to me if that's the most practical option. I
 am a confused by a few things, though:

 * r51358 was only supposed to enable ''logging'' errors, not
 ''displaying'' them. Has this been reproduced in a browser, or just WP-
 CLI? If it's only WP-CLI, then it may be related to how
 [https://github.com/wp-cli/wp-cli/issues/3220 it doesn't always respect
 WP_DEBUG].
 * The change should also only effect `ms-files.php` (multisite media
 proxying), which doesn't seem related to `wp core is-installed`. Does
 reversing this commit locally fix that CLI command?
 * The change was committed 6 months ago, at the start of the 5.9 cycle, so
 it seems odd that it wasn't discovered until just now.

 Regardless, though, the most important thing is a smooth release, so if
 y'all are confident then reverting sounds good.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53493#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform