[wp-trac] [WordPress Trac] #54597: Featured Image section missing on Posts and Pages

WordPress Trac noreply at wordpress.org
Mon Jan 3 22:52:14 UTC 2022

#54597: Featured Image section missing on Posts and Pages
 Reporter:  noisysocks                           |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.9
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots has-patch has-unit-  |     Focuses:
  tests                                          |

Comment (by hellofromTonya):

 Replying to [comment:21 joyously]:
 > I see that there is now a private function
 which does not check the support. That page refers to the old function
 `_wp_render_title_tag()` which did, and that link is 404.

 Right, that private function was added in 5.8.0. In 5.9, in the
 `locate_block_template()` function, the `_wp_render_title_tag` callback is
 unhooked from `'wp_head'` (see https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-includes/block-template.php#L109). In 5.9, the
 `<title>` tag is automatically rendered for block themes. Non-block themes
 are not changed or impacted.

 Replying to [comment:21 joyously]:
 > > Did some testing on 'gallery', 'caption', 'search-form', and
 'navigation-widgets'. Without adding them to the HTML5 theme support
 array, each renders as HTML5. So by default, they are already HTML5. As
 @Mamaduka noted, the block has the markup in it.
 > Again, it sounds like you are talking about blocks, not legacy content
 which millions of sites still have. The theme_support for html5 refers to
 legacy functions that generate the search form (widget or direct call),
 gallery shortcode, caption shortcode, and Menu widgets (this is for a11y).
 > Or are you saying that using a block theme, the legacy content is
 somehow transformed? Or that the block theme doesn't have specific styles
 for anything but blocks so these things don't matter?

 The default theme supports additions are for block themes. Non-block
 themes are not impacted.

 What about the non-block content when using a block theme? Hmm, I was
 curious. So I did a test.

 * Started with WordPress 4.9 and Twenty Fifteen theme. Added a gallery,
 image with caption, and search widget.
 * Then upgraded to 5.9. Result: No changes in the HTML markup. The
 original content in the editor shows the `[gallery]` and `[caption]`
 * Then switched to TT2.
 * Then added default theme support for `'gallery'` and `'caption'`.

 See [attachment:"non-block-caption-54597.png"]. Notice there's no
 difference in the markup before and after adding HTML5 support for both
 `'gallery'` and `'caption'`.

 What do you think @joyously?

Ticket URL: <https://core.trac.wordpress.org/ticket/54597#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list