[wp-trac] [WordPress Trac] #54695: CI: always use `--no-interaction` flag for Composer commands
WordPress Trac
noreply at wordpress.org
Mon Jan 3 22:22:37 UTC 2022
#54695: CI: always use `--no-interaction` flag for Composer commands
------------------------------+-----------------------
Reporter: jrf | Owner: (none)
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 6.0
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+-----------------------
Changes (by jrf):
* status: closed => reopened
* resolution: reported-upstream =>
* milestone: => 6.0
Comment:
Hmmm... I'm don't think the ticket should be closed (yet) as the issue in
the WP builds has not been fixed (yet), though moving it to 6.0 is fine of
course.
At this time, there is no upstream release available containing the
upstream patch, so my patch is still an option.
Once a release from upstream has been tagged, we still won't benefit from
it automatically as all actions used in the CI scripts are locked to a
specific commit hash (for security).
So if we want to wait for the upstream fix before resolving this issue,
the actions steps would be:
1. Review the new release once tagged.
2. Update the commit hash of the action in all CI scripts.
3. Remove any `--no-interaction` arguments which already exist in Composer
commands in the scripts to clean them up (as those are no longer needed).
And then preferably commit the changes for 2+3 in one commit so it is
well-documented/obvious for the next person why the arguments were
removed.
With that in mind, I'm re-opening.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54695#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list