[wp-trac] [WordPress Trac] #54597: Featured Image section missing on Posts and Pages

[WordPress Trac]

#54597: Featured Image section missing on Posts and Pages
-------------------------------------------------+-------------------------
 Reporter:  noisysocks                           |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.9
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots has-patch has-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:15 Mamaduka]:
 >Should the list also have 'title-tag'?
 >I'm not 100% sure about this. @aristath, I think you worked on this part
 of the code for Block Themes. Do you know if we need to declare support?

 No the `<title>` tag is automatically added in a block theme. Adding
 `add_theme_support( 'title-tag' );` doesn't do anything.

 Replying to [comment:17 joyously]:
 > >> so should the list of html5 support include 'gallery', 'caption',
 'search-form', 'navigation-widgets'
 >
 > > The blocks provide their markup; this shouldn't be necessary.
 >
 > You missed the point that the legacy markup can be either html5 or not,
 dependent on the value of the `theme_support`. So for the theme's styles
 to match the markup, it needs to select which markup to use. Or just go
 forward with html5 only.

 Did some testing on `'gallery'`, `'caption'`, `'search-form'`, and
 `'navigation-widgets'`. Without adding them to the HTML5 theme support
 array, each renders as HTML5. So by default, they are already HTML5. As
 @Mamaduka noted, the block has the markup in it.

 This makes sense as core blocks should be HTML5 markup IMO given that it
 was introduced back in 2014. Thinking out loud, supporting legacy and
 HTML5 in blocks seems unnecessary. That said, if there's a use case, I'd
 suggest opening an issue in Gutenberg for discussion and discovery as the
 work would be done there for block packages to be published and then
 backported to Core.

 I'm reclosing this ticket as no additional theme supports are needed for
 5.9.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54597#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform