[wp-trac] [WordPress Trac] #54251: Twenty Twenty: Vertical buttons spacing on frontend dependent on margins

WordPress Trac noreply at wordpress.org
Fri Feb 25 20:10:42 UTC 2022

#54251: Twenty Twenty: Vertical buttons spacing on frontend dependent on margins
 Reporter:  stacimc                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9.2
Component:  Bundled Theme                        |     Version:  5.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |

Comment (by ironprogrammer):

 I'd like to propose that this ticket be `closed`, as the concern was
 resolved with @stacimc's
 [https://github.com/WordPress/gutenberg/pull/34546 PR 34546].

 == Discovery
 A few days after this ticket was originally created,
 [https://github.com/WordPress/gutenberg/pull/34546 PR 34546] introduced a
 c14178789ddd9d29cabe6d9ee7d9335125d74fda3afe9acf8cce7fe1a47f9c0f highly-
 specific override] that prevents the reported margins in "Twenty Twenty"
 from taking effect, resetting them and resulting in:

 .wp-block-buttons > .wp-block-button.wp-block-button.wp-block-button.wp-
 block-button.wp-block-button {
     margin: 0;

 The above ensures that the `gap` setting of the wrapping `.wp-block-
 buttons` controls spacing, which was the original concern voiced in this
 ticket 👍🏻.

 === Screenshots
 Here are current screenshots of the editor and front end (WordPress
 6.0-alpha-52448-src), which render consistently. Buttons within the ''same
 block'' adhere to `gap: 0.5em` set by the editor.

 Additionally, a new row with a button block has been added to show that
 spacing between ''button blocks'' is not being set by the theme, but
 defaulting to editor classic styles.

   [[Image(https://cldup.com/g9_vvCIR5g.png, 50%)]]
   ''Consecutive **Buttons** blocks rendered in post editor.''

   [[Image(https://cldup.com/09D3FTdXJl.png, 50%)]]
   ''Consecutive **Buttons** blocks rendered on front end post page.''

Ticket URL: <https://core.trac.wordpress.org/ticket/54251#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list