[wp-trac] [WordPress Trac] #37189: In wp_term_query on cache ids

WordPress Trac noreply at wordpress.org
Wed Feb 23 11:40:12 UTC 2022


#37189: In wp_term_query on cache ids
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Taxonomy                             |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |  performance
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 In [https://github.com/WordPress/wordpress-develop/pull/2346 #2346], I
 have completely rewritten the patch. All tests are passing now, which is
 pretty neat.

 Some notes on the patch.
 - One just querying by term id, it means that another query has be used to
 prime term caches. This is too be exepected with this change. This change
 brings this query cache inline with other query classes like the post
 query class.
 - One test had to removed, as the last query does not match what it used,
 making the rest invalid.
 - Adding a groupby to query is needed to duplicate queries.
 - Formatting and comments need work.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37189#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list