[wp-trac] [WordPress Trac] #47642: Order by comment count - posts list tables

[WordPress Trac]

#47642: Order by comment count - posts list tables
-------------------------------------------------+-------------------------
 Reporter:  alektabor                            |       Owner:
                                                 |  johnbillion
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Posts, Post Types                    |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch early      |     Focuses:
  early-like-actually-early has-unit-tests       |  administration
-------------------------------------------------+-------------------------

Comment (by msea55):

 @ramon-fincken , thanks for looking into this and taking my suggestion!

 Looking at the patch you uploaded, it looks like it slots in on what is
 now line L2370 in `master`. The particular issue I came across (the
 automatic display of posts by post types in the admin ui) actually came up
 with the behavior that if no sort was provided, "date" became the default
 sort. At the time I said it was line 2328, though I think now it's line
 2348 or 2383, I'm guessing the former but I don't recall the details. If
 your patch slots in where I think it does, it may not account for my case.
 The one on 2348 won't get the secondary sort. And the one on 2883 will get
 the secondary sort but won't get the intended default sort on date. I'd
 probably make the change on what is now line 2389 to cover more cases.

 Anyway, I found a work around for my case, but figured I'd lend my two
 cents in case it helps. Hope I'm not inserting myself too much and thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47642#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform