[wp-trac] [WordPress Trac] #55109: Plugins no longer download to tmp folder

[WordPress Trac]

#55109: Plugins no longer download to tmp folder
-------------------------------------------------+-----------------------
 Reporter:  antonynz                             |       Owner:  Clorith
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9.1
Component:  Filesystem API                       |     Version:  5.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing fixed-major  |     Focuses:
-------------------------------------------------+-----------------------

Comment (by azouamauriac):

 Replying to [comment:6 Clorith]:
 > In [changeset:"52734" 52734]:
 > {{{
 > #!CommitTicketReference repository="" revision="52734"
 > Filesystem API: Use a temp folder for `Content-Disposition` files.
 >
 > #38231 added support for files fetched remotely to have their filename
 defined by the host using the `Content-Disposition` header. This would
 then take priority over the existing temporary file name created with
 `wp_tempnam()` earlier in the process.
 >
 > The change unintentionally omitted the temporary directory path used
 during uploads, since the `wp_tempnam()` function would have added it
 previously, so that files with this header ended up being stored in the
 WordPress root folder, or wp-admin folder, when triggered by WP_Cron or
 user interactions respectively.
 >
 > This change makes sure the file path includes the temporary directory
 location when the header is used.
 >
 > Follow-up to [51939].
 >
 > Props antonynz, azouamauriac.
 > Fixes #55109.
 > }}}

 Hello @Clorith thanks for the commit. I notice that in [52734] you add
 some unit test, that's good, just one thing, in the test function docblock
 you reference the trac ticket like that:

 {{{
 * @ticket #55109
 }}}
 see: [https://prnt.sc/26xt3yp];
 I think it should be:

 {{{
 * @ticket 55109
 }}}
 the "#" should not be there I think. as per doc
 [https://make.wordpress.org/core/handbook/testing/automated-testing
 /writing-phpunit-tests/#annotations] [https://prnt.sc/26xtihw].

 Let me know your thought. thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55109#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform