[wp-trac] [WordPress Trac] #54728: Coding Standards fixes for WP 6.0
WordPress Trac
noreply at wordpress.org
Mon Feb 14 22:12:00 UTC 2022
#54728: Coding Standards fixes for WP 6.0
----------------------------+-------------------------------
Reporter: hellofromTonya | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.0
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: coding-standards
----------------------------+-------------------------------
Comment (by azouamauriac):
Hello @SergeyBiryukov thanks for your great job. I have one concern, I
thought that as "web server" is two words; RE:
[https://www.dictionary.com/browse/web-server],
[https://en.wikipedia.org/wiki/Web_server]; we should use it like this
"$system_web_server_node"
to respect coding standard [https://developer.wordpress.org/coding-
standards/wordpress-coding-standards/php/#naming-conventions]. But I saw
you put it in one word in the commit, is there a raison for that? please
enlighten me.
Replying to [comment:21 SergeyBiryukov]:
> In [changeset:"52721" 52721]:
> {{{
> #!CommitTicketReference repository="" revision="52721"
> Coding Standards: Fix WPCS issues in `wp-admin/includes/misc.php`.
>
> * Use strict comparison in various conditions.
> * Fix a `Variable "$system_webServer_node" is not in valid snake_case
format` WPCS warning.
>
> Includes minor code layout fixes for better readability.
>
> Follow-up to [10607], [11350], [22253], [26137].
>
> Props azouamauriac, SergeyBiryukov.
> See #54728.
> }}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54728#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list