[wp-trac] [WordPress Trac] #50814: Success Message Displays on Failure to Update Site Address

[WordPress Trac]

#50814: Success Message Displays on Failure to Update Site Address
------------------------------+--------------------------------------------
 Reporter:  megabyterose      |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Networks and      |     Version:  5.4.2
  Sites                       |
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  ui, administration, multisite
------------------------------+--------------------------------------------

Comment (by metodiew):

 Hey hey, I've added a new pull request for this ticket and sharing the PR
 message here as well. Open to feedback for the approach!

 Here I'm adding a new class for the dashboard notice class, as we have
 `notice` even if the update fails.
 In addition to that adding a new check if `update_blog_details()` as it's
 returning only `false`.

 I guess the code would need some refactoring and we can place a few
 `apply_filters()` for future extendibility, but wanted to share the first
 version first.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50814#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform