[wp-trac] [WordPress Trac] #54939: When a block theme is active, add Site Editor link and notice to the Customizer UI
WordPress Trac
noreply at wordpress.org
Thu Feb 10 18:13:44 UTC 2022
#54939: When a block theme is active, add Site Editor link and notice to the
Customizer UI
-------------------------------------------------+-------------------------
Reporter: ironprogrammer | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.9.1
Component: Customize | Version:
Severity: normal | Resolution:
Keywords: has-screenshots needs-design- | Focuses: ui, ui-
feedback has-patch i18n-change | copy
-------------------------------------------------+-------------------------
Comment (by antonvlasenko):
> I'd suggest removing "new" from the string, to save ourselves a future
update by making the string more futureproof.
Good spot, @costdev ! Fixed in https://github.com/WordPress/wordpress-
develop/pull/2237/commits/2fd9837872968425d85d008c405727c6680bf2d1
I’ve reworked the UI. Now it looks like that:
1.
[[Image(https://cldup.com/UMny-uzWRQ.png)]]
2.
[[Image(https://cldup.com/RuSqfaEwXe.png)]]
>maybe the "Tell me more" could also be a button-link, as it's technically
an action?
@Clorith I’m sorry, but I don’t understand the advantage of using `button
.button-link`.
It looks like a regular `<a />` tag to me, although it's a `<button />`.
[[Image(https://cldup.com/JHQ4nYaEEB.png)]]
Also, there could be issues with redirecting users to a different domain
using JavaScript.
So I would prefer to use a regular link for `Tell me more` text (as shown
on the first screenshot).
Regarding choosing the text for the notification message: it would be
great if this PR could get some design feedback.
I like the first variant of the text that @ironprogrammer
[https://core.trac.wordpress.org/raw-attachment/ticket/54939/customizer-
site-editor-notice%402x.png proposed].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54939#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list