[wp-trac] [WordPress Trac] #54548: The Close on Escape "feature" on the admin comments page is annoying

WordPress Trac noreply at wordpress.org
Fri Feb 4 15:28:36 UTC 2022


#54548: The Close on Escape "feature" on the admin comments page is annoying
-------------------------+-------------------------------------------------
 Reporter:  BettyJJ      |       Owner:  alexstine
     Type:  defect       |      Status:  accepted
  (bug)                  |
 Priority:  normal       |   Milestone:  6.0
Component:  Comments     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, accessibility, javascript,
                         |  administration
-------------------------+-------------------------------------------------
Changes (by sabernhardt):

 * keywords:  has-patch commit => has-patch


Comment:

 Thanks for the patch, but it's not ready yet.

 1. The PR has a typo: should be "reply" instead of "replay" in the second
 line.
 2. Does the patch improve the interaction for people typing in Chinese or
 Japanese?
 3. Would removing the close-on-escape feature entirely be a better option?
 {{{
 $('#replycontent').trigger( 'focus' );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54548#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list