[wp-trac] [WordPress Trac] #54250: Twenty Twenty One: Editor Buttons margins incompatible with gap

WordPress Trac noreply at wordpress.org
Fri Feb 4 01:55:36 UTC 2022

#54250: Twenty Twenty One: Editor Buttons margins incompatible with gap
 Reporter:  stacimc                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.9.1
Component:  Bundled Theme                        |     Version:  5.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info needs-testing has-  |     Focuses:
  screenshots has-patch                          |

Comment (by ironprogrammer):

 Thank you, @nidhidhandhukiya, for pointing out the margin.

 Backtracking from that selector group reveals that the spacing discrepancy
 relates to margins between **Buttons** blocks themselves, rather than for
 individual buttons. I've opened [https://github.com/WordPress/wordpress-
 develop/pull/2268 PR 2268] to address this in the Twenty Twenty-One (TT1)

 This update makes TT1 behave like previous non-FSE themes, where control
 over editor block margins is controlled by bundled editor styles. The fix
 falls in line with @stacimc's proposed solution, though is technically
 separate from `blockGap` support. Visually, the margins are consistent
 with legacy themes like Twenty Twenty, Twenty Nineteen, etc.

 === Twenty Twenty-One with Fix Applied

Ticket URL: <https://core.trac.wordpress.org/ticket/54250#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list