[wp-trac] [WordPress Trac] #54800: Nonce creation causes DB access errors when initializing multisite networks

[WordPress Trac]

#54800: Nonce creation causes DB access errors when initializing multisite networks
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:
                                                 |  peterwilsoncc
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9.1
Component:  Script Loader                        |     Version:  5.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-testing-info fixed-    |     Focuses:
  major                                          |
-------------------------------------------------+-------------------------

Comment (by dd32):

 Replying to [comment:21 SergeyBiryukov]:
 > Replying to [comment:20 peterwilsoncc]:
 > > Are you noting the history for information purposes or are you after
 some changes prior to merging in to the 5.9 branch?
 >
 > I think I wanted to see if comment:21:ticket:39047 is still relevant,
 but didn't get around to it, so I guess it's just for information purposes
 at this point :)

 I think it's still somewhat valid, but I think leaving [52602] in place
 for trunk is a good idea. I don't see this as being something worth back-
 porting to 5.9.x though, it's not a regression or major bug.

 There's three cases here:
  - Single Site: `wp_installing()` truthful, actually installing, nonces
 unavailable.
  - Multisite Site creation: `wp_installing()` truthful, but nonces
 available due to Network being installed. With [52602] in place, any pages
 where a site is being created, the nonces which are no longer being
 generated here are now unavailable, even though they can be generated.
 Does that cause a problem? Unsure.
  - Multisite Network Creation: `wp_installing()` truthful, but nonces
 unavailable due to Network not being created yet.

 Somewhat importantly, that last one is not exposed via the WordPress UI's
 as far as I know? so it was never really accounted for.

 I guess in part, `wp_installing()` is really being overloaded for multiple
 different things, so doesn't always make total sense.

 Perhaps the fix actually needs to be made lower in the stack, when
 `wp_installing()` functions that trigger DB access should check the table
 exists before accessing it?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54800#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform