[wp-trac] [WordPress Trac] #54906: Check _get_cron_array type in upgrade_590 routine

[WordPress Trac]

#54906: Check _get_cron_array type in upgrade_590 routine
------------------------------------------------+--------------------------
 Reporter:  chrisvanpatten                      |       Owner:
                                                |  peterwilsoncc
     Type:  defect (bug)                        |      Status:  closed
 Priority:  normal                              |   Milestone:  5.9.1
Component:  Upgrade/Install                     |     Version:  5.9
 Severity:  normal                              |  Resolution:  fixed
 Keywords:  has-patch fixed-major dev-reviewed  |     Focuses:
------------------------------------------------+--------------------------
Changes (by peterwilsoncc):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52663" 52663]:
 {{{
 #!CommitTicketReference repository="" revision="52663"
 Upgrade: Prevent warnings upgrading cron array.

 An unvisited site may have an undefined cron array, resulting in
 `_get_cron_array()` returning the value `false`. Previously this would
 trigger warning in `upgrade_590()` as the function assumed
 `_get_cron_array()` would alway return an array.

 No database version change is required as the upgrade routine was
 successful on sites with a cron array during 5.9.0. On sites without a
 cron array, the error has already been thrown if they are running db
 version 51917. This fix is only required for new sites or those upgrading
 that have skipped 5.9.0.

 Follow up to [51917].

 Props chrisvanpatten, kapilpaul, SergeyBiryukov, audrasjb.
 Merges [52656] and [52662] to the 5.9 branch.
 Fixes #54906.
 See #53940.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54906#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform