[wp-trac] [WordPress Trac] #56793: Test tool and unit test improvements for 6.2
WordPress Trac
noreply at wordpress.org
Wed Dec 28 14:07:31 UTC 2022
#56793: Test tool and unit test improvements for 6.2
--------------------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.2
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by SergeyBiryukov):
In [changeset:"55019" 55019]:
{{{
#!CommitTicketReference repository="" revision="55019"
Tests: Bring some consistency to creating and updating objects in factory
classes.
In various unit test factory classes, some of the `create_object()` and
`update_object()` methods returned a `WP_Error` object on failure, while a
few others were documented to do so, but did not in practice, instead
returning the value `0` or `false`, or not accounting for a failure at
all.
This commit aims to handle this in a consistent way by updating the
methods to always return the object ID on success and a `WP_Error` object
on failure.
Includes:
* Updating and correcting the relevant documentation parts.
* Adding missing documentation and `@since` tags in some classes.
* Renaming some variables to clarify that it is the object ID which is
passed around, not the object itself.
Follow-up to [760/tests], [838/tests], [922/tests], [948/tests],
[985/tests], [27178], [32659], [34855], [37563], [40968], [44497],
[46262].
See #56793.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56793#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list