[wp-trac] [WordPress Trac] #56788: PHP 8.0: improvements to allow for named parameters in WP 6.2

[WordPress Trac]

#56788: PHP 8.0: improvements to allow for named parameters in WP 6.2
-------------------------------------------+---------------------
 Reporter:  SergeyBiryukov                 |       Owner:  (none)
     Type:  task (blessed)                 |      Status:  new
 Priority:  normal                         |   Milestone:  6.2
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch has-unit-tests  |     Focuses:
-------------------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"54927" 54927]:
 {{{
 #!CommitTicketReference repository="" revision="54927"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 includes/formatting.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit:
 * Renames the `$string` parameter to `$text` in:
  * `_wp_specialchars()`
  * `wp_specialchars_decode()`
  * `wp_check_invalid_utf8()`
  * `remove_accents()`
  * `_split_str_by_whitespace()`
  * `wp_strip_all_tags()`
 * Renames the `$string` parameter to `$value` in:
  * `backslashit()`
  * `trailingslashit()`
  * `untrailingslashit()`
 * Renames the `$string` parameter to `$subject` in `wp_iso_descrambler()`.
 * Renames the `$match` parameter to `$matches` in `_wp_iso_convert()`.
 * Renames the `$string` parameter to `$date_string` in:
  * `get_gmt_from_date()`
  * `get_date_from_gmt()`
 * Renames the `$string` parameter to`$input` in `wp_parse_str()`.
 * Renames the `$string` parameter to `$content` in
 `wp_pre_kses_block_attributes()`.
 * Amends the `$text` parameter in `wp_pre_kses_less_than()` for
 consistency.

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220],
 [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245],
 [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274],
 [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287],
 [53364], [53365].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #56788.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56788#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform