[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53949" 53949]:
 {{{
 #!CommitTicketReference repository="" revision="53949"
 Code Modernization: Explicitly declare all properties in `WP_Test_Stream`.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 The `WP_Test_Stream` class is a stream wrapper for use in the tests and
 must comply with the PHP requirements for such stream wrappers.

 In this case, the class did not declare the required public `$context`
 property, which led to deprecation notices about the property being
 dynamically created from the `Tests_Image_Editor_Imagick::test_streams()`
 and `Tests_Image_Meta::test_stream()` tests.

 Reference:
 [https://www.php.net/manual/en/class.streamwrapper.php#streamwrapper.props
 PHP Manual: streamWrapper: Properties].

 Follow-up to [49230], [50771], [53557], [53558], [53850], [53851],
 [53852], [53853], [53854], [53856], [53916], [53935], [53936], [53937],
 [53938], [53942], [53945], [53948].

 Props jrf, antonvlasenko.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform