[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53936" 53936]:
 {{{
 #!CommitTicketReference repository="" revision="53936"
 Code Modernization: Remove dynamic properties in
 `WP_Test_REST_Users_Controller`.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 In these particular cases, individual tests set a couple of properties
 (`$author_id`, `$post_id`) that are never used outside of the context of
 the test in which they are created.

 In other words: these should never have been properties, but should be
 local variables instead.

 Follow-up to [38832], [53557], [53558], [53850], [53851], [53852],
 [53853], [53854], [53856], [53916], [53935].

 Props jrf.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform