[wp-trac] [WordPress Trac] #36308: get_attached_file() destroys file paths on Windows

WordPress Trac noreply at wordpress.org
Tue Aug 23 19:57:31 UTC 2022


#36308: get_attached_file() destroys file paths on Windows
-------------------------------------------------+-------------------------
 Reporter:  Whissi                               |       Owner:  antpb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.1
Component:  Media                                |     Version:  4.4.2
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests has-        |     Focuses:
  testing-info needs-testing early commit        |
-------------------------------------------------+-------------------------
Changes (by antpb):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53934" 53934]:
 {{{
 #!CommitTicketReference repository="" revision="53934"
 Media: Account for Windows when normalizing file paths.
 Previously, Windows paths in the `path_is_absolute` function resulted in
 incorrect URIs. This patch adjusts for forward slashes and adds tests for
 the `get_attached_file` function.
 Props Whissi, SergeyBiryukov, desrosj, stevenlinx, birgire, davidbaumwald,
 costdev, peterwilsoncc, audrasjb, hellofromTonya, johnbillion.
 Fixes #36308.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36308#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list