[wp-trac] [WordPress Trac] #56271: Custom Template Parts are Duplicated, rather than being updated (PHP 5.6)

[WordPress Trac]

#56271: Custom Template Parts are Duplicated, rather than being updated (PHP 5.6)
-------------------------------------+-------------------------------------
 Reporter:  jonmackintosh            |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  6.0.2
Component:  Themes                   |     Version:  6.0
 Severity:  major                    |  Resolution:
 Keywords:  has-patch has-unit-      |     Focuses:  administration,
  tests has-screenshots has-         |  performance
  testing-info                       |
-------------------------------------+-------------------------------------
Changes (by ironprogrammer):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests has-
     screenshots has-testing-info


Comment:

 == Test Report

 Patch tested: [https://github.com/WordPress/wordpress-develop/pull/3051 PR
 3051] - LGTM 👍🏻

 === Environment
 - OS: macOS 12.5
 - Browser: Safari 15.6
 - Server: nginx/1.23.1
 - PHP: 5.6.40
 - WordPress: 6.0.2-alpha-53697-src
 - Theme: twentytwentytwo v1.2

 === Actual Results
 - ✅ After patching, customized **Templates** and **Template Parts** are
 no longer displayed in duplicate.

 === Additional Notes
 - Before patch is applied, custom templates are ''repeatedly added''
 between lists when switching between Templates and Template Parts.
 [https://cloudup.com/cjJDuy_WXR1 See this video demonstration.]
 - Also verified that after upgrading from PHP 5.6 to 7.4, templates were
 not shown in duplicate.

 === Supplemental Artifacts
 ''Figures 1-2:'' Templates and Template Parts screens listing customized
 templates multiple times.
 || [[Image(https://cldup.com/zwamIF5Qcg.png)]] ||
 [[Image(https://cldup.com/PjV6ct-qDg.png)]] ||

 ''Figures 3-4:'' Templates and Template Parts screens displaying non-
 matching template types between screens.
 || [[Image(https://cldup.com/xr-3tYbKTK.png)]] ||
 [[Image(https://cldup.com/hMNNT27nOr.png)]] ||

 ''Figures 5-6:'' AFTER PATCH. Templates and Template Parts screens listing
 customized templates only once. ✅
 || [[Image(https://cldup.com/MT7bctJDdM.png)]] ||
 [[Image(https://cldup.com/OTNwZ-odBV.png)]] ||

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56271#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform