[wp-trac] [WordPress Trac] #40039: Remove closing PHP tags from bundled themes

[WordPress Trac]

#40039: Remove closing PHP tags from bundled themes
------------------------------+-------------------------------
 Reporter:  netweb            |       Owner:  desrosj
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  6.1
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  coding-standards
------------------------------+-------------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch commit


Comment:

 I'm a bit torn here.

 On one hand, I do agree with @dd32 in that I don't see much benefit to
 changing this in older themes.

 On the other, it is important that the default themes follow all of the
 recommended coding standards and best practices as much as possible as
 they serve as examples to the greater community. People new to WordPress
 and theming often use these as examples and learn from them.

 However, using the active install numbers to gauge overall usage, it's
 unlikely that a significant number of developers are using the older
 themes as a starting point for a new child theme. In my eyes, this
 decreases the amount of weight to give this argument default themes
 serving as examples to the greater community.

 My current stance is that I think it's reasonable to make this change for
 more recent themes, and I'll make that commit shortly.

 In my opinion, there are three groups I would place the default themes
 into. Block-based themes (Twenty Twenty-Two), modern themes (Twenty
 Seventeen through Twenty Twenty-One), older themes (Twenty Sixteen and
 earlier). My personal line for "more recent themes" is Twenty Seventeen
 and newer, so that's where I'll focus.

 I'll leave this open for a bit longer to allow for some counter points
 arguments to fix this in Twenty Sixteen and earlier.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40039#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform