[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53854" 53854]:
 {{{
 #!CommitTicketReference repository="" revision="53854"
 Code Modernization: Remove dynamic properties in `Tests_File`.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 In this case, as the `$badchars` property never changes, declaring this as
 a class constant is the sensible option.

 As for the `$dir` property (which cannot be turned into a constant due to
 the function call), this is used in multiple tests, so making this
 property explicit makes sense.

 Follow-up to [139/tests], [53557], [53558], [53850], [53851], [53852],
 [53853].

 Props jrf.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform