[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53852" 53852]:
 {{{
 #!CommitTicketReference repository="" revision="53852"
 Code Modernization: Remove dynamic properties in
 `Tests_Media_GetPostGalleries`.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 In this particular case, the test class contains a `set_up()` method that
 sets the `$img_meta` property, which is ''used'' by the tests, but never
 ''changed'' by the tests.

 In other words, setting this property in the `set_up()` is an unnecessary
 overhead and the property should be changed to a class constant.

 Includes renaming the test class to match the
 [https://make.wordpress.org/core/handbook/testing/automated-testing
 /writing-phpunit-tests/#naming-and-organization naming conventions].

 Follow-up to [52190], [53557], [53558], [53850], [53851].

 Props jrf.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform