[wp-trac] [WordPress Trac] #52252: PHP Notice when `monthnum` query var is set without the `year` QV

[WordPress Trac]

#52252: PHP Notice when `monthnum` query var is set without the `year` QV
-------------------------------------------------+-------------------------
 Reporter:  dd32                                 |       Owner:
                                                 |  peterwilsoncc
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.1
Component:  Query                                |     Version:  4.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early needs-unit-tests     |     Focuses:
  commit                                         |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch early needs-unit-tests => has-patch early needs-
     unit-tests commit
 * owner:  (none) => peterwilsoncc
 * status:  reviewing => accepted
 * milestone:  Future Release => 6.1


Comment:

 I've updated the tests in [https://github.com/WordPress/wordpress-
 develop/pull/1027/files the linked pull request] and merged in @dd32's
 patch.

 The tests are weird because they assert `true` is `true` (which is true),
 however they're dummy tests as the real test is to assert that there are
 no notices thrown.

 In
 `Tests_Privacy_wpPrivacyDeleteOldExportFiles::test_non_existent_folders_should_not_cause_errors()`
 there is a similar test that does the same thing. Thus I decided to follow
 precedent rather than add an annotation marking the test not risky.

 I think this is good for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52252#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform