[wp-trac] [WordPress Trac] #56330: When does get_pages() return an array of ints?
WordPress Trac
noreply at wordpress.org
Thu Aug 4 13:45:58 UTC 2022
#56330: When does get_pages() return an array of ints?
-------------------------------------------------+-------------------------
Reporter: malthert | Owner: audrasjb
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.1
Component: Query | Version:
Severity: trivial | Resolution:
Keywords: good-first-bug needs-refresh has- | Focuses: docs
patch |
-------------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: good-first-bug has-patch => good-first-bug needs-refresh has-
patch
Comment:
Thank you for the patch @jigar-bhanushali.
However, I have two small remarks:
- We use the `good-first-bug` keyword as an invitation for new people who
never contributed to WordPress Core before. It's better to keep it for new
contributors.
- Your patch doesn't meet WordPress Coding Standards as the indentation of
the docblock needs to be updated accordingly :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56330#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list