[wp-trac] [WordPress Trac] #56198: Check cache key type

[WordPress Trac]

#56198: Check cache key type
-------------------------+-----------------------------
 Reporter:  tillkruess   |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  6.1
Component:  Cache API    |     Version:  trunk
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |     Focuses:  performance
-------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53818" 53818]:
 {{{
 #!CommitTicketReference repository="" revision="53818"
 Cache API: Validate cache key in `WP_Object_Cache` methods.

 Some plugins may call the `wp_cache_*()` functions with an empty string,
 `false`, or `null` as cache key, usually as a result of not checking the
 return value of another function that's used as the key.

 Previously, this was silently failing, leading to odd behavior at best and
 often breakage due to key collisions.

 A valid cache key must be either an integer number or a non-empty string.

 This commit introduces a quick type check on the given cache keys and adds
 a `_doing_it_wrong()` message that should help plugin developers to notice
 these issues quicker.

 Includes:
 * A check in `update_user_caches()` and `clean_user_cache()` to make sure
 user email is not empty before being cached or removed from cache, as it
 is technically possible to create a user with empty email via
 `wp_insert_user()`.
 * Some minor cleanup in unit tests where the email was passed to
 `wp_insert_user()` incorrectly or was unintentionally reset.

 Props tillkruess, malthert, dd32, spacedmonkey, flixos90, peterwilsoncc,
 SergeyBiryukov.
 Fixes #56198.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56198#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform