[wp-trac] [WordPress Trac] #56323: Undefined variable phpcs error for $new_size_meta

WordPress Trac noreply at wordpress.org
Tue Aug 2 13:58:30 UTC 2022


#56323: Undefined variable phpcs error for $new_size_meta
----------------------------------------+-----------------------
 Reporter:  mehulkaklotar               |       Owner:  (none)
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  6.1
Component:  Media                       |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch needs-unit-tests
 * milestone:  Awaiting Review => 6.1


Comment:

 Thanks for this one, @mehulkaklotar!

 It looks like this was introduced in [53751] as part of #55443.

 It does indeed seem that this variable will not be set here. But I'd like
 to confirm the intention here with those that worked on this change.
 @adamsilverstein and @flixos90, are you able to take a look?

 It would also be great to add a unit test or two to catch this in the
 future.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56323#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list