[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
WordPress Trac
noreply at wordpress.org
Mon Aug 1 05:23:02 UTC 2022
#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
------------------------------------+-------------------------------
Reporter: hztyfoon | Owner: audrasjb
Type: defect (bug) | Status: reviewing
Priority: low | Milestone: 6.1
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: coding-standards
------------------------------------+-------------------------------
Comment (by hztyfoon):
Replying to [comment:30 rudlinkon]:
> So for this case 90 minutes will be `90 * MINUTE_IN_SECONDS` instead of
`1.5 * HOUR_IN_SECONDS` or `HOUR_IN_SECONDS + 30 * MINUTE_IN_SECONDS` and
all the like values will be so so, isn't it?
Thannks a ton @rudlinkon.
That's really a good point. 👍👍👍
I'm not sure if `90 * MINUTE_IN_SECONDS` make more sense than `1.5 *
HOUR_IN_SECONDS`.
Let's see what others think about this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list