[wp-trac] [WordPress Trac] #56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file

[WordPress Trac]

#56293: Use 'MINUTE_IN_SECONDS' for consistency in 'update.php' file
------------------------------------+-------------------------------
 Reporter:  hztyfoon                |       Owner:  audrasjb
     Type:  defect (bug)            |      Status:  reviewing
 Priority:  low                     |   Milestone:  6.1
Component:  Administration          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  coding-standards
------------------------------------+-------------------------------

Comment (by rudlinkon):

 > Sounds good. I guess the rule of thumb would be:
 > * If the value can be represented as an integer (not a fractional)
 number of minutes (hours, etc.), use the appropriate constant multiplied
 by that number.
 > * Otherwise, keep the value as is and add a comment with the units for
 clarity.

 So for this case 90 minutes will be `90 * MINUTE_IN_SECONDS` instead of
 `1.5 * HOUR_IN_SECONDS` or `HOUR_IN_SECONDS + 30 * MINUTE_IN_SECONDS` and
 all the like values will be so so, isn't it?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56293#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform